vendor: support alt registries #7718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
@bors: r+ |
Contributor
|
📌 Commit 723748f has been approved by |
Contributor
|
⌛ Testing commit 723748f with merge 720613d48334e6f24fab286da90f07ce0d4bd150... |
Contributor
|
💔 Test failed - checks-azure |
Contributor
Author
|
I think we have to wait for the next nightly to be published (6 or 7 hours from now?). |
Contributor
bors
added a commit
that referenced
this pull request
Dec 19, 2019
vendor: support alt registries Adds support for alt registries to `cargo vendor`. It mostly worked before, but panicked when trying to display the `.cargo/config` instructions. This isn't entirely elegant, as the source replacement looks like this: ```toml [source.crates-io] replace-with = "vendored-sources" [source."file:///Users/eric/Proj/rust/cargo/target/cit/t0/alternative-registry"] registry = "file:///Users/eric/Proj/rust/cargo/target/cit/t0/alternative-registry" replace-with = "vendored-sources" [source."file:///Users/eric/Proj/rust/cargo/target/cit/t0/gitdep"] git = "file:///Users/eric/Proj/rust/cargo/target/cit/t0/gitdep" branch = "master" replace-with = "vendored-sources" [source.vendored-sources] directory = "vendor" ``` The duplication of the URLs is a little unfortunate. It could use the name of the registry, but that is not readily available and is tricky to obtain. I feel like that is a challenge for another day. Closes #7674.
Contributor
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for alt registries to
cargo vendor. It mostly worked before, but panicked when trying to display the.cargo/configinstructions.This isn't entirely elegant, as the source replacement looks like this:
The duplication of the URLs is a little unfortunate. It could use the name of the registry, but that is not readily available and is tricky to obtain. I feel like that is a challenge for another day.
Closes #7674.