Skip to content

Update termcolor and fwdansi versions #8540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2020
Merged

Update termcolor and fwdansi versions #8540

merged 2 commits into from
Jul 25, 2020

Conversation

@vandenheuvel
Copy link
Contributor

@vandenheuvel vandenheuvel commented Jul 24, 2020 •
edited
Loading

A summary of the changes since 1.0.5:

  • wincolor-1.0.3
  • readme: update readme with various things
  • ci: switch to GitHub Actions and bump MSRV to 1.34.0
  • doc: add notes about tty detection
  • doc: clarify how ANSI colors work
  • env: respect NO_COLOR environment variable
  • edition: switch to Rust 2018
  • deps: drop wincolor dependency
  • msrv: document minimum supported Rust version policy
  • style: use rustfmt
  • api: add option to toggle terminal resetting
  • readme: test examples in README
  • bug: fix clear() and is_none()
  • output: italicized support
  • wincolor-1.0.2
  • wincolor: specify dual-license

@vandenheuvel vandenheuvel changed the title Increace termcolor version from 1.0 to 1.1 Increase termcolor version from 1.0 to 1.1 Jul 24, 2020
@ehuss
Copy link
Contributor

ehuss commented Jul 24, 2020

Can you share what has changed, or what is motivating this change?

@vandenheuvel
Copy link
Contributor Author

vandenheuvel commented Jul 24, 2020

I updated the first comment.

@ehuss
Copy link
Contributor

ehuss commented Jul 24, 2020

OK. It looks like the only user-visible change is the addition of NO_COLOR support. Is that what you are interested in?

I think I'm fine merging this. My hesitancy is because this has historically broken color support on older versions on Windows. There are more details at rust-lang/rust#55769 and kennytm/fwdansi#1 and kennytm/fwdansi#2 and #8089.

I just tried this on Windows 8, and the colors mostly look OK. IIRC, Cargo doesn't use background colors, so the reset issue isn't too much of a problem.

Before merging this, can you also update the fwdansi dependency to "1.1.0"? That is required to get this to work properly.

@vandenheuvel
Copy link
Contributor Author

vandenheuvel commented Jul 25, 2020

@ehuss the general motivation is that it's good to use up-to-date dependencies, e.g. bug fixes will no longer be included in the 1.0 versions, the first example of which is already in the above list.

I increased the fwdansi version as you requested.

@vandenheuvel vandenheuvel changed the title Increase termcolor version from 1.0 to 1.1 Increase termcolor and fwdansi versions Jul 25, 2020
@vandenheuvel vandenheuvel changed the title Increase termcolor and fwdansi versions Update termcolor and fwdansi versions Jul 25, 2020
@ehuss
Copy link
Contributor

ehuss commented Jul 25, 2020

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 25, 2020

📌 Commit dcd49a2 has been approved by ehuss

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 25, 2020
@bors
Copy link
Contributor

bors commented Jul 25, 2020

⌛ Testing commit dcd49a2 with merge a93b317...

@bors
Copy link
Contributor

bors commented Jul 25, 2020

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing a93b317 to master...

@bors bors merged commit a93b317 into rust-lang:master Jul 25, 2020
@ehuss ehuss mentioned this pull request Jul 29, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2020
@bors
Auto merge of rust-lang#74923 - ehuss:update-cargo, r=Mark-Simulacrum
6e50a22 
Update cargo

14 commits in aa6872140ab0fa10f641ab0b981d5330d419e927..974eb438da8ced6e3becda2bbf63d9b643eacdeb
2020-07-23 13:46:27 +0000 to 2020-07-29 16:15:05 +0000
- Fix O0 build scripts by default without `[profile.release]` (rust-lang/cargo#8560)
- Emphasize git dependency version locking behavior. (rust-lang/cargo#8561)
- Update lock file encodings on changes (rust-lang/cargo#8554)
- Fix sporadic lto test failures. (rust-lang/cargo#8559)
- build-std: Fix libraries paths following upstream (rust-lang/cargo#8558)
- Flag git http errors as maybe spurious (rust-lang/cargo#8553)
- Display builtin aliases with `cargo --list` (rust-lang/cargo#8542)
- Check manifest for requiring nonexistent features (rust-lang/cargo#7950)
- Clarify test name filter usage (rust-lang/cargo#8552)
- Revert Cargo Book changes for default edition (rust-lang/cargo#8551)
- Prepare for not defaulting to master branch for git deps (rust-lang/cargo#8522)
- Include `+` for crates.io feature requirements in the Cargo Book section on features (rust-lang/cargo#8547)
- Update termcolor and fwdansi versions (rust-lang/cargo#8540)
- Cargo book nitpick in Manifest section (rust-lang/cargo#8543)
This was referenced Jul 31, 2020
Closed
Closed
@ehuss ehuss added this to the 1.47.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vandenheuvel @ehuss @bors