Skip to content

fix: Add if..else completions in LetStmt and ArgList #20390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChayimFriedman2 merged 1 commit into from
Aug 13, 2025
Merged

fix: Add if..else completions in LetStmt and ArgList #20390

ChayimFriedman2 merged 1 commit into from
Aug 13, 2025

Conversation

@A4-Tacks
Copy link
Member

@A4-Tacks A4-Tacks commented Aug 5, 2025

Example

let x = $0;

Old completions:

let x = if $1 {
    $0
};

This PR current completions:

let x = if $1 {
    $2
} else {
    $0
};

@A4-Tacks
Add if..else completions in LetStmt and ArgList
5704431 
Example
===
```rust
let x = $0;
```

Old completions:

```rust
let x = if $1 {
    $0
};
```

This PR current completions:

```rust
let x = if $1 {
    $2
} else {
    $0
};
```
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2025
@ChayimFriedman2
Copy link
Contributor

ChayimFriedman2 commented Aug 12, 2025

I'm torn whether we should name them "if else" to reflect their emitted code, or "if" for consistency with the normal case. @rust-lang/rust-analyzer thoughts?

@Veykril
Copy link
Member

Veykril commented Aug 13, 2025

Keeping if as the name seems fine to me

ChayimFriedman2
ChayimFriedman2 approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Aug 13, 2025
Merged via the queue into rust-lang:master with commit b06ce60 Aug 13, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2025
@lnicola lnicola changed the title Add if..else completions in LetStmt and ArgList fix: Add if..else completions in LetStmt and ArgList Aug 13, 2025
@A4-Tacks A4-Tacks deleted the if-else-comp-in-args-or-let branch August 14, 2025 08:48
@A4-Tacks A4-Tacks mentioned this pull request Nov 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChayimFriedman2 ChayimFriedman2 ChayimFriedman2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@A4-Tacks @ChayimFriedman2 @Veykril @rustbot