Setup infrastructure to allow Auxv information to be passed from crashed process. #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Shadle
requested changes
Jul 17, 2024
Jake-Shadle
approved these changes
Jul 23, 2024
gabrielesvelto
approved these changes
Aug 5, 2024
Contributor
gabrielesvelto
left a comment
There was a problem hiding this comment.
LGTM too, @marti4d is this ready for merging?
Collaborator
Author
|
@gabrielesvelto It is! And the sooner, the better, since I'm going to have to get this vendored into M-C so the C++ part of my change can use it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the crashed process supports it, it can directly pass in the needed values from the auxiliary vector to avoid potential issues where "/proc/{pid}/auxv" can't be accessed on Android.
If the information is not passed in (or is incomplete), the code will attempt to fill in any gaps from the auxv file. If any of this fails, it will now just log a warning message and continue writing the minidump.
Fixes #27