Skip to content

fix: set TERM env variable for terminal to fix Delete key not working #13747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
majiayu000 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: set TERM env variable for terminal to fix Delete key not working #13747

majiayu000 wants to merge 1 commit into from

Conversation

@majiayu000
Copy link

@majiayu000 majiayu000 commented Dec 8, 2025

Summary

  • Set TERM=xterm-256color environment variable when spawning PTY shell
  • This ensures proper handling of terminal control sequences

Problem

Delete/Backspace keys were not working in terminal connections, particularly when connecting from iPad to Linux.

Root cause: The PTY was spawning shell without setting the TERM environment variable, causing the shell to not properly interpret certain control character sequences.

Solution

Added cmd.env("TERM", "xterm-256color") in terminal_service.rs before spawning the shell process. This tells the shell it's running in an xterm-compatible terminal, enabling proper handling of:

  • Delete key (\x7f)
  • Backspace key
  • Arrow keys and other special keys

Test plan

  • Connect from iPad to Linux via terminal
  • Type text and press Delete/Backspace
  • Verify characters are correctly deleted
  • Run echo $TERM and verify output is xterm-256color

Fixes #13621

@majiayu000
fix: set TERM env variable for terminal to fix Delete key not working
126a1fb 
Set TERM=xterm-256color when spawning PTY shell to ensure proper
handling of control sequences. This fixes the issue where Delete/
Backspace keys were not working in terminal connections, particularly
from iPad to Linux.

Fixes rustdesk#13621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Delete-key not working inside terminal

1 participant

@majiayu000