Skip to content

Conversation

@Gaurav-Verma07
Copy link
Contributor

@Gaurav-Verma07 Gaurav-Verma07 commented Mar 7, 2024

Related issue: #335

Create a global error handling model having following fields:

  • errorCode
  • message

Used vue-toastification library to show error messages.
Implemented the error handling in signin page (signin() )

image

@Gaurav-Verma07
Copy link
Contributor Author

Hii @jvJUCA , hope you're doing well!!!

Apologies for the late PR (I was having issues with my system).

I've created a globalErrorHandler component as discussed.
The model contains 2 parameters {errorCode, message}
For now I've implemented it only Auth.js/signin() so that you can review the core functionality first.
If the errorModel is as per our expectations, I'll extend it to the whole codebase.

@Gaurav-Verma07
Copy link
Contributor Author

Also, I'm getting this warning in the console... I'm trying but maybe you can help here :)

image

Copy link
Member

@jvJUCA jvJUCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gaurav-Verma07
Congratulations! 🎉 Your pull request has been accepted! Thank you for your valuable contribution.

Your changes have been merged successfully and will be included in the develop branch. Your effort in improving our project is greatly appreciated.

Thanks again for your contribution, and we look forward to your continued involvement in our project!

Best regards,
@jvJUCA

@jvJUCA jvJUCA merged commit d4ed758 into ruxailab:develop Mar 11, 2024
@Gaurav-Verma07
Copy link
Contributor Author

Hey @jvJUCA ,
I still have to add new GlobalErrorHandler at every place we use setError otherwise it may misbehave.
For now, I had only included it for signin page errors.

Should I open a new issue to resolve this?

@jvJUCA
Copy link
Member

jvJUCA commented Mar 11, 2024

Hey @jvJUCA , I still have to add new GlobalErrorHandler at every place we use setError otherwise it may misbehave. For now, I had only included it for signin page errors.

Should I open a new issue to resolve this?

Yes, i think you will need to change the set errors around the code, can you create this issue?

@Gaurav-Verma07
Copy link
Contributor Author

Create new Issue.. working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants