Skip to content

Add script to automatically register a new TruffleRuby release in RVM#4576

Merged
havenwood merged 2 commits into
rvm:masterfrom
eregon:add-update-truffleruby-script
Feb 4, 2019
Merged

Add script to automatically register a new TruffleRuby release in RVM#4576
havenwood merged 2 commits into
rvm:masterfrom
eregon:add-update-truffleruby-script

Conversation

@eregon
Copy link
Copy Markdown
Contributor

@eregon eregon commented Jan 15, 2019

This automates adding a new TruffleRuby version in RVM, and avoids copy-paste errors.

Where should I place the script?
For now, I added it at the root of the repo like e.g., update-remote.sh.

cc @pkuczynski @havenwood @nirvdrum

@eregon
Copy link
Copy Markdown
Contributor Author

eregon commented Jan 15, 2019

BTW, is it necessary to update the ChangeLog for TruffleRuby releases? This would remain as a manual step as there is no easy way to predict the PR number.

Comment thread update-truffleruby.rb Outdated
@eregon
Copy link
Copy Markdown
Contributor Author

eregon commented Jan 27, 2019

@pkuczynski Could you merge this PR?

@havenwood
Copy link
Copy Markdown
Member

On the question of where to put it, I wonder if it'd be worth keeping it top level but renaming it update-versions.sh with just a truffleruby argument for now? (Similar to ruby-versions' update.sh.)

@eregon
Copy link
Copy Markdown
Contributor Author

eregon commented Feb 4, 2019

I'm not looking forward to generalize the script for all Ruby implementations at this time, I'd rather merge what works and is useful now.

I could rename to update-versions.rb and only support truffleruby, but that seems slightly misleading for me.

@eregon
Copy link
Copy Markdown
Contributor Author

eregon commented Feb 4, 2019

@havenwood @pkuczynski Please tell me what changes you want before merging, and then let's merge it 😃

@havenwood
Copy link
Copy Markdown
Member

Since it's an internal, contributor-facing script I think we can merge it as-is, then move it to update-versions.rb truffleruby once we have another engine's update script to add.

@havenwood havenwood merged commit 68816c5 into rvm:master Feb 4, 2019
@havenwood
Copy link
Copy Markdown
Member

Thank you for the PR!

@eregon
Copy link
Copy Markdown
Contributor Author

eregon commented Feb 4, 2019

Thanks for merging!

@pkuczynski
Copy link
Copy Markdown
Member

Sorry, was on holiday...

@pkuczynski pkuczynski added this to the rvm-1.29.8 milestone Feb 4, 2019
@eregon
Copy link
Copy Markdown
Contributor Author

eregon commented Feb 5, 2019

@pkuczynski No worry. I wanted to merge this soon as it allows to simplify these instructions quite a bit:
truffleruby/truffleruby@1217310?short_path=7400bc7 (and of course makes it much easier to update TruffleRuby in RVM).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants