Skip to content

Update glow and remove it from the public API #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ryanisaacg wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update glow and remove it from the public API #38

ryanisaacg wants to merge 3 commits into from

Conversation

@ryanisaacg
Copy link
Owner

@ryanisaacg ryanisaacg commented Sep 12, 2020 •
edited
Loading

Users shouldn't be subjected to breaking golem changes for every single glow breakage (which are pretty common, because glow has a bigger API surface.)

Additionally, stdweb is not longer a priority because it is unmaintained. Only web-sys will be supported going forward.

Closes #33

@ryanisaacg
Update glow and remove it from the public API
33e6649 
Users shouldn't be subjected to breaking golem changes for every single
glow breakage (which are pretty common, because glow has a bigger API
surface.)

Additionally, stdweb is not longer a priority because it is
unmaintained. Only web-sys will be supported going forward.
@ryanisaacg
Format
433e10d
@ryanisaacg
Update workflows
c6292ea
@coolreader18
Copy link

coolreader18 commented Jan 22, 2021 •
edited
Loading

What if, instead of manually having the cfg for every instantiation, there was a function on blinds::Window like fn gl_initializer(&self) -> {impl FnMut(&str) -> *const c_void OR web_sys::WebGLRenderingContext} and a function on golem::Context like fn from_gl_init(init: {impl FnMut.. OR web_sys::...}). That way it's sort of just a convention (i.e. no semver dependencies), and it's still easy to create a golem context from a blinds window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanisaacg @coolreader18