Skip to content

Conversation

@bieniu
Copy link
Contributor

@bieniu bieniu commented Jun 20, 2021

zhimi.humidifier.ca1 same aszhimi.humidifier.cb2 reports 127 whithout water tank and 125 when water tank is full.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2021

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.40%. Comparing base (89a9ed9) to head (15f67be).
Report is 378 commits behind head on master.

Files Patch % Lines
miio/airhumidifier.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1077   +/-   ##
=======================================
  Coverage   75.40%   75.40%           
=======================================
  Files          73       73           
  Lines        8367     8367           
  Branches      745      745           
=======================================
  Hits         6309     6309           
  Misses       1874     1874           
  Partials      184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@rytilahti rytilahti merged commit a377d76 into rytilahti:master Jun 20, 2021
@bieniu bieniu deleted the humidifier-water-level branch June 21, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants