Fix uninitialized mission safety for Photo Recon #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the MisSaf field for the Photo Recon when performing Mission Setup. This continues a bug fix in d2b5c1b. Fixes raceintospace#482. Because the MissionType.Hard array does not include a slot for Mission_PhotoRecon, Photo Recon was not being properly added to the mission hardware array (the global MH). Commit d2b5c1b explicitly added Photo Recon to all missions, but overlooked setting the mission safety field MisSaf that tests are rolled against. This commit fixes that. This also sets the MissionType.Hard[Mission_EVA] field in the VAB on manned missions, so MissionSetup() isn't tacitly relying on the field being initialized to a default of 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the MisSaf field for the Photo Recon when performing Mission Setup.
This continues a bug fix in d2b5c1b.
Fixes #482.
Because the MissionType.Hard array does not include a slot for
Mission_PhotoRecon, Photo Recon was not being properly added to the mission
hardware array (the global MH). Commit d2b5c1b explicitly added
Photo Recon to all missions, but overlooked setting the mission safety
field MisSaf that tests are rolled against. This commit fixes that.
This also sets the MissionType.Hard[Mission_EVA] field in the VAB on
manned missions, so MissionSetup() isn't tacitly relying on the field
being initialized to a default of 0.