Fix DM getting max R&D value after catastrophic failure #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in the safety factor reduction after a catastrophic failure that led to DMs getting assigned a maximum R&D value. Fixes raceintospace#730.
|
Is that what it was? |
|
The underlying issue is that the MSF variable in the Equipment struct (which is normally used to store the original Max R&D) is used for the safety factor of the hardware power-on step during a docking mission. That's why you saw a Max R&D of 96%, which came from the safety factor of your orbital satellite.
|
|
Good to know. Thanks for taking care of it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the safety factor reduction after a catastrophic failure that led to DMs getting assigned a maximum R&D value. Fixes #730.