Skip to content

Conversation

@hweimer
Copy link
Contributor

@hweimer hweimer commented Dec 21, 2023

Fixes several out-of-bounds memory reads in the AI and astronaut code.

Fixes several out-of-bounds memory reads in the AI code.
@peyre peyre merged commit e0d1a7f into raceintospace:master Dec 21, 2023
@peyre
Copy link
Member

peyre commented Dec 21, 2023

Great to hear! What sort of issues did it fix? I'd like to add it to the changelog.

@hweimer
Copy link
Contributor Author

hweimer commented Dec 22, 2023

Hard to tell, these bugs led to undefined behavior. This could have caused anything, from having no effect on the actual gameplay, to random crashes, to the AI code not working as intended (I remember you sharing a story along these lines, although I think it is unlikely that these bugs had anything to do with that.) I think the most likely outcome is that, occasionally, the AI would do something it was not supposed to do, but it is unclear whether that would be favoring the AI or the opponent.

@peyre
Copy link
Member

peyre commented Dec 22, 2023

Thanks! I'll write it up.

@sflynn850 sflynn850 added this to the Release 2.0 milestone Jun 12, 2024
@sflynn850 sflynn850 added the Bug An issue that causes a crash or an invalid or undesirable game state. label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug An issue that causes a crash or an invalid or undesirable game state.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants