-
Notifications
You must be signed in to change notification settings - Fork 104
Minor Errors #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rojas70
wants to merge
187
commits into
rail-berkeley:main
Choose a base branch
from
learningLogisticsLab:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Minor Errors #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when calling the test/test_gym_env_human.py. Need to add width and height & cameraid to the MujocoRenderer instantiation.
…ings to facilitate student understanding.
…r.py as well as improving how variables are passed in
…nto fractal_replay_buffer
- Set original image resolution to (960,960,3) for easy viewing.
- Need to resize these images in the SERLObsWrapper such that image specs match those expected by DRQ as well as ensure they are of type uint8.
- resize function added that can work with cv2 or PIL.
- Call to observation returns state and resized images. Lots of checks here.
- Can record demos for any number of episodes.
- Keyboard bindings use the following keys:
moveBindings = {
'i':(1,0,0,0),
',':(-1,0,0,0),
'j':(0,1,0,0),
'l':(0,-1,0,0),
'u':(0,0,0,1),
'o':(0,0,0,-1),
'm':(0,0,1,0),
'.':(0,0,-1,0),
}
Note that after commanding actions the robot has some momentum that current controller does not cancel well. You will need practice.
- Data gets stored to data customized folders that are checked for existance or created.
…s well using: a,d,w,s,q,e to change azimuth, elevation, and distance. - code checks first for cam if so, then checks for action. if no cam, then just checks for action.
- correctly updates OXEEnvLogger generated files to be read by TFDS tfds.builder_from_directory in launcher.py - When running outside debugger still get an exception that I need to work out, but can be used to move forward.
…nto fractal_replay_buffer
…into sparse-reach
- Changing name of env to sparse reach version. - In demos branch, fixing jax.tree.leaves.
- Reward is 1 for success cases based on the error norm proximity. - Slight change to step function. - Increased max-steps to 200 for this environment.
… using a format similar to the following:
└── franka_reach_drq_demo_script
├── session_20250914_210112_num_demos_2
│ └── PandaReachSparseCube-v0
│ └── 0.1.0
│ ├── dataset_info.json
│ ├── features.json
│ └── PandaReachSparseCube-v0-train.tfrecord-00000
Succeeded in recording 2,5,10 demos for Panda Reach Sparse with Cube.
…b/serl into sparse-reach
…b/serl into sparse-reach
rojas70
commented
Oct 21, 2025
Author
rojas70
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately what name are we using for the environment. I thought we had agreed on a 'Vision' named environment.
Currently I see: PandaReachSparseCube
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 422d207 fixes a bug in the way the Mujoco Renderer is instantiated so that there is no crush when calling. test_gym_env_human.py.
Commit 7e23bbd includes a critic_actor_ratio that is missing when agent.high_utd_ratio is called.
Others...