SPA provider (vite) #1257
Merged
SPA provider (vite) #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
no idea why the lunatic one is failing |
coffee-cup
reviewed
Jan 15, 2025
Contributor
coffee-cup
left a comment
There was a problem hiding this comment.
Nice work! This will definitely make it easier for people coming from Vite apps.
Do you know how this will interact with users who have a custom nixpacks.toml and Caddy file for deploying static sites already?
Contributor
Author
|
I'm not sure, but the Caddyfile wouldn't overwrite the users. And im pretty sure it would just use what's in nixpacks.toml as opposed to what the SPA provider generates. |
…packs into milo/spa-provider
coffee-cup
reviewed
Jan 16, 2025
coffee-cup
approved these changes
Jan 16, 2025
Contributor
coffee-cup
left a comment
There was a problem hiding this comment.
Looks good! I've tested on various repos and it works well 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a Vite SPA provider which will automatically run supported applications with Caddy.
It can be configured via NIXPACKS_SPA_CADDY to turn off Caddy, or if you want to turn Caddy on for an application that doesn't automatically get detected, you can specify a build directory with the NIXPACKS_SPA_OUT_DIR variable.
Detection
Vite is detected by:
vitedependencyvite.config.jsorvite.config.tsvite buildOutput directory:
outDiris invite.config.js/ts--outDiris in the build scriptCaddy:
reactvuesvelte(but not@sveltejs/kit)preactlitsolid-js@builder.io/qwik