add versioning support for golang provider #150
Conversation
|
|
||
| match matched_version { | ||
| Some((_, pkg)) => Ok(Some(pkg.to_string())), | ||
| None => bail!("Go version {} is not available", version), |
There was a problem hiding this comment.
I think if the version isn't specified we should default to the go package. Thoughts?
There was a problem hiding this comment.
I agree, this should be how we handle it for all providers. If the version isn't found, default to the version on the nixos tag (like the node provider).
There was a problem hiding this comment.
The node provider will actually error out if you specify a version in engines that's not in the list of supported versions (I tested the behavior myself). I wanted to preserve the same behavior as on node. But I can change this later.
There was a problem hiding this comment.
There's a difference between specifying unsupported version and not specifying any version. Node provider falls back to default version if version isn't specified.
coffee-cup
left a comment
There was a problem hiding this comment.
Looks good (besides falling back to default go version if none found)! Thanks for adding this.
Added support for retrieving the Go version number from
go.mod(if exists). Also added an example and tests for the version parsing method, the docker run output, and plan generation.Note: I've also updated
examples/go-mod, as it was pointing to a Go version that's not available on nix unstable.Closes #148