Always manage connections when database is specified #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a database is specified, we should always manage connections so that we can ensure the cache is writable. But if you just use the default connection for the rest of the app, we won't attempt to manage that. Fixes: #214
flavorjones
added a commit
to basecamp/fizzy
that referenced
this pull request
Mar 4, 2025
Because solid cache started using shard swapping when given a `database:` key in rails/solid_cache#219, and Rails doesn't distinguish which database is being swapped and which was locked. Hopefully I can make a change upstream that will enable swap locking only for a specific databases. Until then, let's just use a slightly more verbose configuration to work around it.
flavorjones
added a commit
to basecamp/fizzy
that referenced
this pull request
Mar 6, 2025
Because solid cache started using shard swapping when given a `database:` key in rails/solid_cache#219, and Rails doesn't distinguish which database is being swapped and which was locked. Hopefully I can make a change upstream that will enable swap locking only for a specific databases. Until then, let's just use a slightly more verbose configuration to work around it.
flavorjones
added a commit
to basecamp/fizzy
that referenced
this pull request
Mar 6, 2025
Because solid cache started using shard swapping when given a `database:` key in rails/solid_cache#219, and Rails doesn't distinguish which database is being swapped and which was locked. Hopefully I can make a change upstream that will enable swap locking only for a specific databases. Until then, let's just use a slightly more verbose configuration to work around it.
flavorjones
added a commit
to basecamp/fizzy
that referenced
this pull request
Mar 6, 2025
Because solid cache started using shard swapping when given a `database:` key in rails/solid_cache#219, and Rails doesn't distinguish which database is being swapped and which was locked. Hopefully I can make a change upstream that will enable swap locking only for a specific databases. Until then, let's just use a slightly more verbose configuration to work around it.
flavorjones
added a commit
to basecamp/fizzy
that referenced
this pull request
Mar 10, 2025
Because solid cache started using shard swapping when given a `database:` key in rails/solid_cache#219, and Rails doesn't distinguish which database is being swapped and which was locked. Hopefully I can make a change upstream that will enable swap locking only for a specific databases. Until then, let's just use a slightly more verbose configuration to work around it.
flavorjones
added a commit
to basecamp/fizzy
that referenced
this pull request
Mar 11, 2025
Because solid cache started using shard swapping when given a `database:` key in rails/solid_cache#219, and Rails doesn't distinguish which database is being swapped and which was locked. Hopefully I can make a change upstream that will enable swap locking only for a specific databases. Until then, let's just use a slightly more verbose configuration to work around it.
flavorjones
added a commit
to basecamp/fizzy
that referenced
this pull request
Mar 12, 2025
Because solid cache started using shard swapping when given a `database:` key in rails/solid_cache#219, and Rails doesn't distinguish which database is being swapped and which was locked. Hopefully I can make a change upstream that will enable swap locking only for a specific databases. Until then, let's just use a slightly more verbose configuration to work around it.
flavorjones
added a commit
to basecamp/fizzy
that referenced
this pull request
Mar 12, 2025
Because solid cache started using shard swapping when given a `database:` key in rails/solid_cache#219, and Rails doesn't distinguish which database is being swapped and which was locked. Hopefully I can make a change upstream that will enable swap locking only for a specific databases. Until then, let's just use a slightly more verbose configuration to work around it.
monorkin
added a commit
to basecamp/fizzy
that referenced
this pull request
Nov 14, 2025
flavorjones
pushed a commit
to basecamp/fizzy
that referenced
this pull request
Nov 17, 2025
jzimdars
pushed a commit
to basecamp/fizzy
that referenced
this pull request
Nov 17, 2025
kevinmcconnell
pushed a commit
to basecamp/fizzy
that referenced
this pull request
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a database is specified, we should always manage connections so that we can ensure the cache is writable.
But if you just use the default connection for the rest of the app, we won't attempt to manage that.
Fixes: #214