Skip to content

feat(assocPath): add support for Symbols#3506

Open
char0n wants to merge 1 commit into
ramda:masterfrom
char0n:char0n/2137
Open

feat(assocPath): add support for Symbols#3506
char0n wants to merge 1 commit into
ramda:masterfrom
char0n:char0n/2137

Conversation

@char0n
Copy link
Copy Markdown
Contributor

@char0n char0n commented Jan 20, 2025

Refs #2137

@char0n char0n mentioned this pull request Jan 20, 2025
@github-actions
Copy link
Copy Markdown

Coverage Summary
> ramda@0.30.1 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register

�[2J�[1;3H
1202 passing (1s)


=============================== Coverage summary ===============================
Statements   : 94.07% ( 2490/2647 )
Branches     : 85.85% ( 977/1138 )
Functions    : 93.28% ( 555/595 )
Lines        : 94.35% ( 2338/2478 )
================================================================================

Copy link
Copy Markdown

@dylan-chong dylan-chong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not fully adding support for symbols ( i suppose to be thorough we'd need to add tests for everything else to be consistent - prop, lens, evolve, etc) but i'm happy with this as it just unbreaks the functionality for now

I'm happy with this being a silent, not officially support symbols, but fix the bug anyway PR.

thanks so much for submitting the PR so quickly @char0n 🙇

@char0n
Copy link
Copy Markdown
Contributor Author

char0n commented Jan 20, 2025

this is not fully adding support for symbols ( i suppose to be thorough we'd need to add tests for everything else to be consistent - prop, lens, evolve, etc) but i'm happy with this as it just unbreaks the functionality for now

I'm happy with this being a silent, not officially support symbols, but fix the bug anyway PR.

thanks so much for submitting the PR so quickly @char0n 🙇

It's just a start and a precedence ;]
I was waiting 8 years to issue this PR ;]

@Harris-Miller
Copy link
Copy Markdown
Contributor

The shallow-clone behavior of assoc copies only enumerable properties. Symbols are inherently non-enumerable. Personally not a fan of adding Symbol support here. It breaks existing expectations and conventions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants