Skip to content

docs(pipeWith): add usage example#3520

Merged
kedashoe merged 3 commits into
ramda:masterfrom
bmehder:add-pipeWith-example
Aug 6, 2025
Merged

docs(pipeWith): add usage example#3520
kedashoe merged 3 commits into
ramda:masterfrom
bmehder:add-pipeWith-example

Conversation

@bmehder
Copy link
Copy Markdown
Contributor

@bmehder bmehder commented Aug 1, 2025

I noticed the code example for the pipeWith function is not showing on the documentation page. I felt like the same example for composeWith would serve as a reasonable example. This is the first PR I have done, so my apologies if I have done anything incorrectly.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 1, 2025

Coverage Summary
> ramda@0.31.3 coverage:summary
> BABEL_ENV=cjs nyc --reporter=text-summary mocha -- --reporter=min --require @babel/register

�[2J�[1;3H
1209 passing (933ms)


=============================== Coverage summary ===============================
Statements   : 94.1% ( 2519/2677 )
Branches     : 85.9% ( 981/1142 )
Functions    : 93.37% ( 563/603 )
Lines        : 94.36% ( 2361/2502 )
================================================================================

Copy link
Copy Markdown
Contributor

@kedashoe kedashoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for the pr! Not sure why it wasn't rendering. I'm ok with the changes, but can you update the new lines to have the 6 spaces at the beginning of each line? We look for that when rendering the examples.

@bmehder
Copy link
Copy Markdown
Contributor Author

bmehder commented Aug 2, 2025

Done! I fixed the indentation as requested. Let me know if you’d like anything else adjusted.

kedashoe
kedashoe previously approved these changes Aug 2, 2025
Copy link
Copy Markdown
Contributor

@kedashoe kedashoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty!

Comment thread package-lock.json
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry one more thing, can we revert this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it — I’ll revert package-lock.json and push an update.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! I’ve removed the package-lock.json changes as requested.

@kedashoe kedashoe merged commit 7414650 into ramda:master Aug 6, 2025
1 check passed
@bmehder
Copy link
Copy Markdown
Contributor Author

bmehder commented Aug 6, 2025

Thanks for merging!

@bmehder bmehder deleted the add-pipeWith-example branch February 18, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants