Skip to content

can't modify frozen String when run with --enable=frozen-string-literal flag #665

Description

@khiav223577

My rails project, which is running with RUBYOPT="--enable-frozen-string-literal", encounter this problem.
The Error message is:

Failure/Error: package.serialize(tempfile)

     FrozenError:
       can't modify frozen String: ""
     # /home/khiav/.rvm/gems/ruby-3.0.0/gems/axlsx-2.0.1/lib/axlsx/rels/relationships.rb:23:in `to_xml_string'
     # /home/khiav/.rvm/gems/ruby-3.0.0/gems/axlsx-2.0.1/lib/axlsx/package.rb:197:in `parts'
     # /home/khiav/.rvm/gems/ruby-3.0.0/gems/axlsx-2.0.1/lib/axlsx/package.rb:160:in `write_parts'
     # /home/khiav/.rvm/gems/ruby-3.0.0/gems/axlsx-2.0.1/lib/axlsx/package.rb:105:in `block in serialize'
     # /home/khiav/.rvm/gems/ruby-3.0.0/gems/rubyzip-1.0.0/lib/zip/output_stream.rb:49:in `open'
     # /home/khiav/.rvm/gems/ruby-3.0.0/gems/axlsx-2.0.1/lib/axlsx/package.rb:104:in `serialize'

It looks like the default arguments of to_xml_string method is a frozen string when running with the flag.

def to_xml_string(str = '')

I suggest we replace '' with String.new, so that the empty string will never be frozen.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Done in caxlsxThis has already been solved in the caxlsx fork.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions