Autostart speedup when a CMD HD drive is configured. #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propsed pull request for issue: #299
If a CMDHD is configured in a drive (e.g. 10), and there is no image mounted, the autostart time is impacted and changes from almost instant to 5-10 seconds.
Looking through the CMD HD log output there is quite a lot of calls to cmdhd_store and cmdhd_read even when there is no image attached. Simple making these function return immediately seems to fix the issue.
This fix isn't from the upstream Vice repo, and I think is only needed here because the Pi3 is a low powered device in comparision.
I've tested loading various D64, CRT and a CMD HD with C64OS on it.
I also first had to fix a few compile errors in the logging code.