Skip to content

Conversation

@CheyuWu
Copy link
Collaborator

@CheyuWu CheyuWu commented Oct 20, 2025

Why are these changes needed?

The dashboard function clusterIsRayJob (dashboard/src/utils/v2/filter.ts) relies on the legacy custom label mlp.rbx.com/component to detect RayJob-originated clusters. As a result, RayJob-created clusters that only include the official KubeRay label ray.io/originated-from-crd=RayJob are not recognized as RayJobs in the UI.

Update clusterIsRayJob to:

  • Check labels["ray.io/originated-from-crd"] === "RayJob" (case-insensitive).
  • Fall back to mlp.rbx.com/component for legacy environments.

Manual Testing

Launch API server and frontend server

$ go run cmd/main.go -httpPortFlag :31888 -cors-allow-origin=*

$ yarn dev

Create only RayCluster

$ k apply -f ray-operator/config/samples/ray-cluster.sample.yaml

Create RayCluster + RayJob

$ k apply -f ray-operator/config/samples/ray-job.sample.yaml

RayCluster - all
image

RayCluster - Cluster
image

RayCluster - Job
image

Related issue number

Closes #4134

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Cheyu Wu <cheyu1220@gmail.com>
@CheyuWu CheyuWu changed the title [Bug] [KubeRay] Dashboard misclassifies RayCluster type [Bug] [KubeRay Dashboard] Dashboard misclassifies RayCluster type Oct 20, 2025
@CheyuWu CheyuWu changed the title [Bug] [KubeRay Dashboard] Dashboard misclassifies RayCluster type [Bug] [KubeRay Dashboard] Misclassifies RayCluster type Oct 20, 2025
@CheyuWu
Copy link
Collaborator Author

CheyuWu commented Oct 21, 2025

Hi @han-steve , Could you please take a look

@han-steve
Copy link
Contributor

thanks for the fix!

@rueian rueian merged commit 7e6c11e into ray-project:master Oct 23, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [KubeRay Dashboard] Misclassifies RayCluster type

3 participants