-
Notifications
You must be signed in to change notification settings - Fork 670
[Feature] TLS authentication #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
YQ-Wang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We can also mention that the gencert scripts can be prebaked into the docker container so the configMap approach is optional. Otherwise lgtm.
architkulkarni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Some minor comments/questions, but they shouldn't block the PR
Co-authored-by: Archit Kulkarni <architkulkarni@users.noreply.github.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: Archit Kulkarni <architkulkarni@users.noreply.github.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Updated 376c9b5. |
TLS authentication
Why are these changes needed?
Ray can be configured to use TLS on it’s gRPC channels (ref). However, the document requires users to have related knowledge about TLS, HTTPS, and basic cryptography to create correct public-private key pairs, self-signed certificates, and certificate authority.
In KubeRay, users also need to know how does head / workers communicate with each other.
POD_IPto communicate with worker.FQ_RAY_IP) to communicate with the head.Hence, head needs to have
FQ_RAY_IP's certificate, and worker requires the certificate of itsPOD_IP.Configuring TLS in KubeRay can be a challenging task for users. To ease this process, this PR offers detailed instructions and an example YAML file, simplifying the setup and configuration of TLS for users
Credit: This is a joint effort. Over the last two weeks, @YQ-Wang and I have been working closely together on this and other issues, synchronizing almost every day.
Related issue number
Closes #889
Checks
head Pod's log

worker Pod's log

Verift the TLS authentication (Step 4 in the doc)