Skip to content

Conversation

@zcin
Copy link
Contributor

@zcin zcin commented Jun 9, 2023

Why are these changes needed?

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421
Copy link
Member

Should we close this PR?

@zcin
Copy link
Contributor Author

zcin commented Jun 15, 2023

Closing in favor of a separate approach in #1156

@zcin zcin closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants