Add support for openshift routes #1183
Conversation
|
@kevin85421, can you, please, take a look at the errors, they do not seem to be related to my PR |
|
@kevin85421, nm, fixed it |
kevin85421
left a comment
There was a problem hiding this comment.
Would you mind providing more details about how to manually test it? Unfortunately, I don't have access to OpenShift, so I am unable to test it by myself.
| name: {{ $fullName }} | ||
| labels: | ||
| {{- include "kuberay-apiserver.labels" . | nindent 4 }} | ||
| {{- with .Values.route.annotations }} |
There was a problem hiding this comment.
Why do we use with here instead of if? In this YAML file, we have used if twice and with once. Should we strive for consistency?
There was a problem hiding this comment.
This again is copied from ingress.yaml and does work
You just run |
|
I ran |
Have you ever sent a request via the route to check if the KubeRay API Server can receive the request and create a RayCluster successfully? If so, I will merge this PR. |
Of course |
Add support for openshift routes
Why are these changes needed?
API server Helm chart allows creating an ingress, but for the OpenShift, the default way to expose services is the usage of Route. This PR adds support for Routes creation
Related issue number
Checks