Skip to content

Conversation

@architkulkarni
Copy link
Contributor

Why are these changes needed?

The docstring of runtimeEnv didn't appear right above the runtimeEnv field. This PR fixes the issue.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@architkulkarni
Copy link
Contributor Author

Compatibility test failure unrelated, merging.

@architkulkarni architkulkarni merged commit b26f106 into ray-project:master Jul 18, 2023
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Jul 20, 2023
…1242)

The docstring of runtimeEnv didn't appear right above the runtimeEnv field. This PR fixes the issue.

---------

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Jul 20, 2023
…1242)

The docstring of runtimeEnv didn't appear right above the runtimeEnv field. This PR fixes the issue.

---------

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…1242)

The docstring of runtimeEnv didn't appear right above the runtimeEnv field. This PR fixes the issue.

---------

Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants