[GCS FT] Consider the case of sidecar containers #1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
architkulkarni
approved these changes
Sep 5, 2023
Contributor
architkulkarni
left a comment
There was a problem hiding this comment.
Looks great! A couple of very minor notes:
- Currently, the definition of "when does KubeRay restart a Ray pod" only appears in the PR description, and the implementation of
shouldDeletePod. I think it should appear in user facing docs somewhere, what do you think? Or is that too technical? - [Nit] Consider parametrizing the new test with 6 cases; I think it can be done using "table driven tests".
This was referenced Sep 5, 2023
Member
Author
|
2 tasks
z103cb
pushed a commit
to z103cb/kuberay
that referenced
this pull request
Sep 11, 2023
Consider the case of sidecar containers
z103cb
pushed a commit
to z103cb/kuberay
that referenced
this pull request
Sep 11, 2023
Consider the case of sidecar containers
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Consider the case of sidecar containers
8 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In PR #1341, KubeRay is configured to delete the pods that have a
Neverrestart policy and are in terminal states (i.e.,Succeeded,Failed). However, an edge case exists for Pods equipped with sidecar containers.According to this Kubernetes document, a Pod status of
Runningindicates that "at least one container is still running, or is in the process of starting or restarting." This leads to a situation where the Ray cluster may never recover from a failure, as illustrated below:Never.ray startprocess in the Ray container, which subsequently will not restart.Runningstatus, given that the sidecar container continues to operate.In this PR, we will check the status of the Ray container instead of checking the Pod's status only.
Related issue number
Closes #1355
Checks