created HA example for API server #1461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@z103cb, @tedhtchang, @anishasthana please take a look |
4 tasks
z103cb
approved these changes
Oct 2, 2023
Contributor
z103cb
left a comment
There was a problem hiding this comment.
Small nit picks around spelling and not so obvious steps. Otherwise this is LGTM.
Contributor
Author
|
@tedhtchang. Can you take a look as well |
z103cb
approved these changes
Oct 5, 2023
tedhtchang
reviewed
Oct 5, 2023
tedhtchang
reviewed
Oct 5, 2023
tedhtchang
reviewed
Oct 5, 2023
tedhtchang
reviewed
Oct 5, 2023
tedhtchang
reviewed
Oct 5, 2023
tedhtchang
reviewed
Oct 5, 2023
tedhtchang
reviewed
Oct 5, 2023
tedhtchang
reviewed
Oct 5, 2023
tedhtchang
reviewed
Oct 5, 2023
tedhtchang
reviewed
Oct 5, 2023
tedhtchang
reviewed
Oct 5, 2023
Contributor
Author
|
@kevin85421 can you. please, merge |
z103cb
reviewed
Oct 9, 2023
z103cb
approved these changes
Oct 9, 2023
Contributor
Author
|
@kevin85421 still waiting for you to merge |
Contributor
Author
|
@tedhtchang looks like you have not approved this yet |
Contributor
Contributor
Author
kevin85421
approved these changes
Oct 11, 2023
Member
kevin85421
left a comment
There was a problem hiding this comment.
I haven't reviewed this PR, but two folks from IBM have approved it. Stamp.
4 tasks
kevin85421
pushed a commit
to kevin85421/kuberay
that referenced
this pull request
Oct 17, 2023
kevin85421
added a commit
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
There is a great document on Ray cluster HA with KubeRay https://docs.ray.io/en/master/cluster/kubernetes/user-guides/kuberay-gcs-ft.html. This PR shows how to do this using an API server.
It also implements changes to the API cluster to support this
The PR also provides step-by-step instructions for creating and testing the HA Ray cluster using the API server
Related issue number
Checks