[RayJob]: Always use target RayCluster image as default RayJob submitter image #1548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kevin85421 @z103cb @blublinsky for your review, thanks. |
blublinsky
approved these changes
Oct 19, 2023
| Name: "ray-job-submitter", | ||
| // Use the image of the Ray head to be defensive against version mismatch issues | ||
| Image: rayClusterInstance.Spec.HeadGroupSpec.Template.Spec.Containers[0].Image, | ||
| Resources: v1.ResourceRequirements{ |
Contributor
There was a problem hiding this comment.
Very nice
We can now remove the check in the API server
kevin85421
reviewed
Oct 19, 2023
Member
kevin85421
left a comment
There was a problem hiding this comment.
Thank you for the contribution! Would you mind adding some unit tests for the function?
Contributor
Author
@kevin85421 I've added a unit test and re-pushed. PTAL. |
kevin85421
pushed a commit
to kevin85421/kuberay
that referenced
this pull request
Nov 2, 2023
kevin85421
added a commit
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue number
Closes #1547.
Checks