updating url use v1 #1577
updating url use v1 #1577
Conversation
|
@z103cb, @tedhtchang, @astefanutti pls, take a look cc: @kevin85421 |
tedhtchang
left a comment
There was a problem hiding this comment.
@blublinsky 4 file still have the the v1alpha2 curl examples. Do we need to change these?
./test/service/service:curl 'localhost:8888/apis/v1alpha2/namespaces/default/services'
./test/service/service:curl 'localhost:8888/apis/v1alpha2/services'
./test/service/service:curl -X DELETE localhost:8888/apis/v1alpha2/namespaces/default/services/test-v2
./test/service/serviceV1:curl -X POST 'localhost:8888/apis/v1alpha2/namespaces/default/services'
./test/service/serviceV2:curl -X POST 'localhost:8888/apis/v1alpha2/namespaces/default/services'
./test/job/query:curl -X GET 'localhost:8888/apis/v1alpha2/namespaces/default/jobs'
./test/job/query:curl -X GET 'localhost:8888/apis/v1alpha2/jobs'
./test/job/query:curl -X GET 'localhost:8888/apis/v1alpha2/namespaces/default/jobs/job-test'
./test/job/query:curl -X DELETE 'localhost:8888/apis/v1alpha2/namespaces/default/jobs/job-test' \
|
Thanks @tedhtchang for catching this. fixed |
|
@kevin85421 I think this one is ready for commit |
kevin85421
left a comment
There was a problem hiding this comment.
I rerun the failed CI tests. I will merge this PR when CI passes.
Why are these changes needed?
As we are gearing to v1 this PR updates API server URLs to reflect V1
All proto files are updated to use V1 in URL. Additionally test files and readme were updated to reflect this change
Related issue number
Checks