[Test][RayJob] Transition to Complete if the JobStatus is STOPPED
#1871
Conversation
Complete if the JobStatus is STOPPED
astefanutti
left a comment
There was a problem hiding this comment.
LTGM. This is great!
| from ray.job_submission import JobSubmissionClient | ||
|
|
||
| print("Sleep 20 seconds to enable the RayJob to transition to RUNNING state") | ||
| time.sleep(20) |
There was a problem hiding this comment.
Could we pass in submission ID into stop.py and poll the job status until it's RUNNING?
There was a problem hiding this comment.
I agree. Or could we even delete the sleep entirely? Isn't it be guaranteed to be RUNNING at the time this Python code is being executed?
There was a problem hiding this comment.
RUNNING here refers to JobDeploymentStatus rather than JobStatus.
Isn't it be guaranteed to be RUNNING at the time this Python code is being executed?
JobStatus guaranteed to be RUNNING at the time this Python code is being executed. That's why I said "RayJob transition to RUNNING state" instead of "Ray job".
There was a problem hiding this comment.
I see, thanks for clarifying. Sleeping in a test isn't ideal but I don't know a better way right now
There was a problem hiding this comment.
Yes, we don't have a method to know the JobDeploymentStatus without implementing some RBAC configurations.
Why are these changes needed?
This is the test for #1855.
Related issue number
Closes #1866
Checks