Skip to content

Conversation

@edward2a
Copy link
Contributor

Why are these changes needed?

To allow customisation of the dnsConfig for ray pods.

Related issue number

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421
Copy link
Member

@MortalHappiness can you review this PR?

@MortalHappiness
Copy link
Member

@edward2a could you add comments for these variables to helm-chart/ray-cluster/values.yaml?

@edward2a
Copy link
Contributor Author

edward2a commented Oct 4, 2024

@edward2a could you add comments for these variables to helm-chart/ray-cluster/values.yaml?

Sure thing, I'll find some time today or Monday and add comments with a short sample.

@kevin85421
Copy link
Member

@edward2a any updates?

@edward2a
Copy link
Contributor Author

edward2a commented Oct 9, 2024

@edward2a any updates?

@MortalHappiness apologies for the delay, time is limted.
Now updated, let me know for any further changes required.

Copy link
Member

@MortalHappiness MortalHappiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin85421 kevin85421 merged commit 9a0b9d0 into ray-project:master Oct 10, 2024
Ygnas pushed a commit to Ygnas/kuberay that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants