[Refactor][RayService] Unify ClusterAction decision to single function #2716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f109493 to
7bb1438
Compare
Closes: ray-project#2706 Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
7bb1438 to
579310c
Compare
Member
|
cc @rueian would you mind reviewing this PR? |
kevin85421
approved these changes
Jan 8, 2025
Member
kevin85421
left a comment
There was a problem hiding this comment.
Love the PR! Very clean and well tested!
| return rayServiceInstance, nil | ||
| } | ||
|
|
||
| func isZeroDowntimeUpgradeEnabled(ctx context.Context, rayService *rayv1.RayService) bool { |
Member
There was a problem hiding this comment.
add unit tests for this function.
Member
Author
There was a problem hiding this comment.
Already covered in this test
ray-operator/controllers/ray/rayservice_controller_unit_test.go
Outdated
Show resolved
Hide resolved
rueian
approved these changes
Jan 8, 2025
Collaborator
|
LGTM. |
Closes: ray-project#2706 Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Ygnas
pushed a commit
to Ygnas/kuberay
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See the description in the corresponding issue for details.
Related issue number
Closes: #2706
Checks