Skip to content

Conversation

@hcc429
Copy link
Contributor

@hcc429 hcc429 commented Jan 3, 2025

Why are these changes needed?

refactor validateServiceSpec

Related issue number

Closes #2710

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: hcc429 <dev.hcc29@gmail.com>
@kevin85421 kevin85421 self-assigned this Jan 3, 2025
@kevin85421 kevin85421 merged commit a7197c5 into ray-project:master Jan 4, 2025
24 checks passed
Ygnas pushed a commit to Ygnas/kuberay that referenced this pull request Mar 20, 2025
Signed-off-by: hcc429 <dev.hcc29@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[refactor] Check whether UpgradeStrategy is nil and UpgradeStrategy.Type is valid in a single if statement

2 participants