[Chore] Make error as a local variable #2841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fscnick <fscnick.dev@gmail.com>
kevin85421
approved these changes
Jan 28, 2025
Member
kevin85421
left a comment
There was a problem hiding this comment.
would you mind checking whether is there any lint rule to check this?
owenowenisme
pushed a commit
to owenowenisme/kuberay
that referenced
this pull request
Jan 29, 2025
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Collaborator
Author
It seems not able to do that under There was a rule if trying to enable |
Ygnas
pushed a commit
to Ygnas/kuberay
that referenced
this pull request
Mar 20, 2025
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Make the
erras local variable in if-statement because they are used in the scope only.Related issue number
Checks