Skip to content

Conversation

@kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Jan 31, 2025

Why are these changes needed?

Replace env test with unit tests which have higher coverage and much faster.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: kaihsun <kaihsun@anyscale.com>
@kevin85421 kevin85421 changed the title [RayService] Add unit tests for isZeroDowntimeUpgradeEnabled [RayService] Add unit tests for isZeroDowntimeUpgradeEnabled Jan 31, 2025
@kevin85421
Copy link
Member Author

I am fixing the test.

Signed-off-by: kaihsun <kaihsun@anyscale.com>
@kevin85421 kevin85421 marked this pull request as ready for review February 1, 2025 00:37
@kevin85421 kevin85421 merged commit 77a1023 into ray-project:master Feb 1, 2025
24 checks passed
@kevin85421 kevin85421 mentioned this pull request Feb 2, 2025
48 tasks
Ygnas pushed a commit to Ygnas/kuberay that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants