[RayService] Add an envtest for autoscaler #2872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
237
to
244
| // (1) Create a RayService custom resource | ||
| // (2) The RayService controller creates a pending RayCluster | ||
| // (3) Ray Autoscaler scales up the RayCluster | ||
| // (4) The RayService controller should not trigger zero downtime upgrade | ||
| // (5) The serve application becomes ready on the pending RayCluster | ||
| // (6) The pending RayCluster transitions to become the active RayCluster | ||
| // (7) Ray Autoscaler scales up the RayCluster again | ||
| // (8) The RayService controller should not trigger zero downtime upgrade |
Member
There was a problem hiding this comment.
Do we still need these comments? Maybe they can be merged into the description of It. And then in the future if we want to add more It in the middle, we don't need to change a lot of numbers in the comment here.
Member
Author
There was a problem hiding this comment.
I made the comment more generic.
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
kevin85421
commented
Feb 1, 2025
| Eventually( | ||
| getResourceFunc(ctx, client.ObjectKey{Name: rayService.Name, Namespace: "default"}, rayService), | ||
| time.Second*3, time.Millisecond*500).Should(BeNil(), "My myRayService = %v", rayService.Name) | ||
| *rayService.Spec.RayClusterSpec.WorkerGroupSpecs[0].Replicas++ |
Member
Author
There was a problem hiding this comment.
This is also used to simulate Ray Autoscaler.
MortalHappiness
approved these changes
Feb 1, 2025
48 tasks
Ygnas
pushed a commit
to Ygnas/kuberay
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks