Skip to content

Conversation

@owenowenisme
Copy link
Member

@owenowenisme owenowenisme commented Feb 3, 2025

Why are these changes needed?

Related issue number

#2878
Test 2

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: owenowenisme <mses010108@gmail.com>
@owenowenisme owenowenisme changed the title add zero-downtime triggered test after rayVersion is triggered [RayService] Add zero-downtime triggered test after rayVersion is triggered Feb 3, 2025
@owenowenisme owenowenisme changed the title [RayService] Add zero-downtime triggered test after rayVersion is triggered [RayService] Add zero-downtime triggered test after rayVersion is updated. Feb 3, 2025
@owenowenisme owenowenisme changed the title [RayService] Add zero-downtime triggered test after rayVersion is updated. [RayService] Add zero-downtime triggered test after rayVersion is updated Feb 3, 2025
@owenowenisme
Copy link
Member Author

@kevin85421 PTAL🙏.

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this PR, and Ruei-An will open a follow up PR if needed.

@kevin85421 kevin85421 merged commit 355de9a into ray-project:master Feb 3, 2025
24 checks passed
@owenowenisme owenowenisme deleted the rayservice-controller-test-add-envtest-zero-downtime-upgrade branch February 4, 2025 01:48
@kevin85421 kevin85421 mentioned this pull request Feb 4, 2025
4 tasks
Ygnas pushed a commit to Ygnas/kuberay that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants