Skip to content

[Release] Update KubeRay version references for 1.4.1 #3848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevin85421 merged 1 commit into from
Jul 6, 2025
Merged

[Release] Update KubeRay version references for 1.4.1 #3848

kevin85421 merged 1 commit into from
Jul 6, 2025

Conversation

@rueian
Copy link
Collaborator

@rueian rueian commented Jul 5, 2025 •
edited
Loading

Why are these changes needed?

As title. Update version reference for formal 1.4.1 release.

Related issue number

#3847

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@rueian rueian marked this pull request as ready for review July 5, 2025 02:06
@rueian rueian force-pushed the release-1.4 branch 2 times, most recently from 0917372 to 1fabdad Compare July 5, 2025 02:08
kevin85421
kevin85421 reviewed Jul 5, 2025
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the changes that are unnecessary (e.g. release.md)? We should try to simplify the release process.

@rueian
[Release] Update KubeRay version references for 1.4.1
bce4dc0 
Signed-off-by: Rueian <rueiancsie@gmail.com>
@rueian
Copy link
Collaborator Author

rueian commented Jul 5, 2025

Can we remove the changes that are unnecessary (e.g. release.md)? We should try to simplify the release process.

Ok, just removed those changes and made this PR touch the same files as the previous release PR.

kevin85421
kevin85421 approved these changes Jul 6, 2025
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check whether the release doc needs to be updated or not?

@kevin85421 kevin85421 merged commit 3d138cf into ray-project:release-1.4 Jul 6, 2025
25 checks passed
@rueian
Copy link
Collaborator Author

rueian commented Jul 6, 2025

Can you check whether the release doc needs to be updated or not?

Yes, the release doc is missing two steps:

# Create a tag
git tag v1.4.0
git tag ray-operator/v1.4.0 # <--- this one

and

git push upstream v1.4.0
git push upstream ray-operator/v1.4.0 # <--- this one

Since ray-operator is still a separate Go submodule, we need to create and push the ray-operator/v1.4.x tag to make it available via go get.

@kevin85421
Copy link
Member

kevin85421 commented Jul 7, 2025

@rueian can you open a PR to update the doc?

@rueian
Copy link
Collaborator Author

rueian commented Jul 7, 2025

@rueian can you open a PR to update the doc?

here #3849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

@MortalHappiness MortalHappiness Awaiting requested review from MortalHappiness

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rueian @kevin85421