Skip to content

[dx] warn early about deprecated skipped rules, as not neccessary to skip anymore #7742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 2 commits into from
Dec 9, 2025
Merged

[dx] warn early about deprecated skipped rules, as not neccessary to skip anymore #7742

TomasVotruba merged 2 commits into from
Dec 9, 2025
+99 −17

Conversation

@TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Dec 9, 2025 •
edited
Loading

Ref: rectorphp/rector#9543

Rector already warns about rules that are used, but deprecated. That way they can be removed/adjusted in time.

For the skip option we don't have such reporting yet, so it can lead to sudden removal.

return RectorConfig::configure()
->withSkip([
        \Rector\Php81\Rector\Array_\FirstClassCallableRector::class,
]);

This PR fixes that :)

Screenshot From 2025-12-09 11-46-51

@TomasVotruba TomasVotruba changed the title tv skip depre warn [dx] warn early about deprecated skipped rules, as not neccessary to skip anymore Dec 9, 2025
@TomasVotruba TomasVotruba merged commit ca6cf9c into main Dec 9, 2025
58 checks passed
@TomasVotruba TomasVotruba deleted the tv-skip-depre-warn branch December 9, 2025 10:53
@TomasVotruba TomasVotruba mentioned this pull request Dec 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomasVotruba