fix(responsive): prevent infinite layout oscillation in toolbox pattern #2192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When items were removed from the layout and re-added (toolbox pattern), they would flicker infinitely between their correct size and default 1x1. Root cause: The layout sync from props used useEffect which runs AFTER render. When props changed, GridLayout received stale layout state on the first render, creating items with default dimensions, triggering callbacks that updated props, causing an infinite loop. Fix: Use useMemo to derive layout synchronously during render, ensuring GridLayout always receives correct layout on the same render cycle as children changes. Also use effectiveLayout in compactType effect to avoid stale data during concurrent changes. Added regression tests for the toolbox remove/re-add scenario and StrictMode double-render compatibility.
38ab625 to
fdd52a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When items were removed from the layout and re-added (toolbox pattern), they would flicker infinitely between their correct size and default 1x1.
Root cause: The layout sync from props used useEffect which runs AFTER render. When props changed, GridLayout received stale layout state on the first render, creating items with default dimensions, triggering callbacks that updated props, causing an infinite loop.
Fix: Use useMemo to derive layout synchronously during render, ensuring GridLayout always receives correct layout on the same render cycle as children changes. Also use effectiveLayout in compactType effect to avoid stale data during concurrent changes.
Added regression test for the toolbox remove/re-add scenario.
Description
This PR [adds/removes/fixes/replaces] the [feature/bug/etc].
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?