Skip to content

Integrate Fuzzy Search for suggestions聽#984

Description

@ad1992

We want to support the fuzzy search for suggestions and for that, we can use a library

Let's use fuzzify to support fuzzy search for suggestions - dogfooding 馃摝 馃榾

Activity

  1. shrilakshmishastry commented on Aug 1, 2024

    @shrilakshmishastry
    Contributor

    Hey @ad1992 I would like to take up this task

  2. ad1992 commented on Aug 1, 2024

    @ad1992
    MemberAuthor

    sure go ahead @shrilakshmishastry

  3. shrilakshmishastry commented on Aug 3, 2024

    @shrilakshmishastry
    Contributor

    Hey @ad1992 here is the short description of the above task

    Problem statement

    • Use fuzzy logic to render suggestions in react-tags based on query input

    current functionality

    The method used to filter suggestions is filteredSuggestions(). This method uses string matching for all items in the suggestion. Keeping exact match in the beginning and partial match at the end

    new functionality

    replace this filtering methodology with fuzzy logic.

    expected from the task is to use a library called fuzzify for string search.

  4. shrilakshmishastry commented on Aug 3, 2024

    @shrilakshmishastry
    Contributor

    is above understanding is correct?

  5. ad1992 commented on Aug 3, 2024

    @ad1992
    MemberAuthor

    is above understanding is correct?

    @shrilakshmishastry yes, but to clarify - you need not implement your own fuzzy logic for rendering the suggestions as that's taken care of by fuzzify, you need to only integrate the library fuzzify npm package in this library for suggestions so that fuzzy search is supported for suggestions
    Let me know if you have any questions

  6. shrilakshmishastry commented on Aug 3, 2024

    @shrilakshmishastry
    Contributor

    It's clear to me.

  7. ad1992 commented on Aug 3, 2024

    @ad1992
    MemberAuthor

    @shrilakshmishastry if you face any issues in integration, please let me know as the fuzzify is at a very early stage and I am looking for feedback as well :)

  8. AndyClausen commented on Dec 3, 2024

    @AndyClausen

    Wouldn't it be better to expose an onSearch event to allow users to provide their own search functionality? Then you can do the search on backend or database level, for example. You can still provide a default search. This way, no more deps are added as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions