Add OS Build options to readme #176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed the readme doesn't include that you may need to change your package.json depending on your OS
This was referenced Sep 21, 2019
EP36
approved these changes
Oct 2, 2019
Collaborator
EP36
left a comment
There was a problem hiding this comment.
Looks great. Appreciate it!
ghost
approved these changes
Dec 8, 2019
ghost
suggested changes
Dec 8, 2019
ghost
left a comment
There was a problem hiding this comment.
platform=windows
should be: platform=win32
Author
|
Following up as this has been stuck for ~6 months now with only 1 approver 😢 Would like to either close the request or get it completed 🙂 |
novacoole
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the readme will build a MacOS binary. Added instructions for MacOS, Linux & Windows for clarity