Better identify Swift default implementations#1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves identification of default implementations for Swift protocols. This improves the spec projects’ documentation in a couple of ways, identifying a few methods that were skipped or wrongly identified as mentioned in #1420.
It does not work when type inference is required to make the method a default implementation as seen in AlamofireExtended - but the change is an overall improvement.
Does not work for SymbolGraph — we don’t have the type information (might be available by massaging the data) and SymGraph has the same bug as jazzy when it tries to actively spot default implementations (swiftlang/swift#61285). Which is a shame.
Fixes #1420.