Skip to content

Conversation

@gozora
Copy link
Member

@gozora gozora commented Oct 27, 2016

Applied changes discussed in #1052.

@jsmeix jsmeix added enhancement Adaptions and new features cleanup minor bug An alternative or workaround exists labels Oct 28, 2016
@jsmeix jsmeix self-assigned this Oct 28, 2016
@jsmeix jsmeix added this to the Rear v1.20 milestone Oct 28, 2016
@jsmeix
Copy link
Member

jsmeix commented Oct 28, 2016

@gozora
if this pull request is finished from your point of view
I woulkd just merge it.

@gozora
Copy link
Member Author

gozora commented Oct 28, 2016

@jsmeix Yes, it is.

@jsmeix jsmeix merged commit 8504328 into rear:master Oct 28, 2016
@jsmeix
Copy link
Member

jsmeix commented Oct 28, 2016

I found a typo in a comment in default.conf:

# into ReaRs local.conf/site.conf.

(i.e. the plural ...s is used here).
It should be

# into ReaR's local.conf/site.conf.

(i.e. the genitive ...'s is actually meant)

No need to do a pull request only because of this.
Perhaps you can include it in a future pull request.

@gozora
Copy link
Member Author

gozora commented Oct 28, 2016

@jsmeix I'll correct it, just give me a minute ;-)

@gozora
Copy link
Member Author

gozora commented Oct 28, 2016

ah you've merged it already ...
So fine, I'll note it somewhere ...

@jsmeix
Copy link
Member

jsmeix commented Oct 28, 2016

I found another minor issue in default.conf:

On my system I get:

$ less usr/share/rear/conf/default.conf
...
# When set, use the given path/filename as remote path (default is â200234borgâ200235)
...
$ file usr/share/rear/conf/default.conf
usr/share/rear/conf/default.conf: UTF-8 Unicode English text

You use UTF-8 characters.
Please use only simple traditional (7-bit) ASCII charactes, cf.
#1018 (comment)

@jsmeix
Copy link
Member

jsmeix commented Oct 28, 2016

I added a section "Character Encoding" to
https://github.com/rear/rear/wiki/Coding-Style

@gozora
Copy link
Member Author

gozora commented Oct 28, 2016

That was an accident. Since my grammar fiasco. I use Libreoffice for spellchecks ...

@jsmeix
Copy link
Member

jsmeix commented Oct 28, 2016

Ahhh!
You trust robots (LibreOffice) more than yourself ;-))

@gozora
Copy link
Member Author

gozora commented Oct 28, 2016

Of course I do! :-)

@gozora
Copy link
Member Author

gozora commented Oct 28, 2016

apt-get install geany-plugin-spellcheck (hopefully) did the trick. Now I can look smart and use right encoding as well :-)

jsmeix added a commit that referenced this pull request Oct 28, 2016
@jsmeix
Copy link
Member

jsmeix commented Oct 28, 2016

Right now I remember that I can simply fix such minor typos
directly via the GitHub web frontend which I did hereby:
6ccbab0

@gozora
Copy link
Member Author

gozora commented Oct 28, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup enhancement Adaptions and new features fixed / solved / done minor bug An alternative or workaround exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants