-
-
Notifications
You must be signed in to change notification settings - Fork 269
ebiso image size is too small if BACKUP is TSM #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Regardless that I know basically nothing at all about Provide a new variable in default.conf like # The size of the UEFI boot image in KiB. # It must be big enough for initrd and kernel. # If unset or empty rear will use default/fallback values: # Usually 32000 KiB should be sufficient. # When elilo or shim is used 128000 KiB should be sufficient. # Additional space is needed when special backup restore software # is used (e.g. additional 96000 KiB when TSM is used): EFIBOOT_IMAGE_SIZE_KiB=32000 and use that in the efiboot_img_size function. Reasoning: As far as I understand it from #810 (comment) Work-around, if any I have modified rear code: extended UEFI image size by experimentally determined value for this particular setup the main problem is how to automatically determine When there is no reliably working automatism, A possible enhancement request: I wonder why the size is measured in KiB and not in MiB. By the way: I needed reverse engineering to find out that the measurement unit dd if=/dev/zero of=$TMP_DIR/efiboot.img count=$(efiboot_img_size) bs=1024 I wished variable names were more meaningful, cf. |
|
Thanks for feedback! Frankly, I am against adding new variable to the config file (there is too many of them already), as we can find the needed value automatically (by counting the total size of the to-be-copied files). ReaR user should not be forced to determine the space needed for uefi boot image I think. I absolutely agree with the variable names and units comment. Also [[ ... ]] && ... does not seem to honor the style as i read it now :) |
|
At the time I was writing ebiso, I primary focused to implement it into ReaR with least pain possible. |
|
@pavoldomin My above comment was made under the (wrong) assumption that "there is no reliably working automatism". When rear "can find the needed value automatically (by counting the total size of the to-be-copied files)" it should do that and not bother the user with tasks that can be reliably automated. |
|
@gozora I am not really the right one for this issue because |
The patch increases the UEFI image size, if BACKUP is TSM. The reference issue: #810
I must admit I start to dislike this UEFI image size determination code (which is my own partly).
Perhaps we should think about more scientific approach to calculate needed size for the UEFI image?
On the other hands its just few lines of code (compared to bit more if 'more scientific approach' is in place). Any comments please?