-
-
Notifications
You must be signed in to change notification settings - Fork 269
First steps for downloadin config files into the recovery system. #945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First steps for downloadin config files into the recovery system. #945
Conversation
…very first basically working version in init/default/03_update_recovery_system.sh (issue 841)
…very first basically working version in init/default/03_update_recovery_system.sh (issue 841)
of https://github.com/jsmeix/rear into first_steps_for_download_config_issue841
|
@gdha It is a pure additional functionality so that |
|
Got no objections and I cannot imagine what could break |
| # therefore the HTTP response code is written to stdout ('-w') so that it can be explicitly tested afterwards | ||
| # ('-s' does not show progress meter or error messages but 'S' it makes it show an error message if it fails) | ||
| # "curl --verbose" messages go to stderr so that they go to the "rear recover" log file: | ||
| local http_response_code=$( curl $verbose -f -s -S -w "%{http_code}" -o /$update_archive_filename $RECOVERY_UPDATE_URL ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsmeix just make sure that curl is added to the REQUIRED_PROGS array if we depend on it in recovery mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gdha
in my current first step state one must do that manually via
REQUIRED_PROGS=( "${REQUIRED_PROGS[@]}" curl )
see my description in default.conf.
The new RECOVERY_UPDATE_URL functionality
will require further enhancements and then - as needed
by the usres - I will try to make things work more
automatically right out of the box.
|
Unfortunately in the Git commit message |
|
For a possible use case, see #943 |
In general see #841
For the particular state see
#841 (comment)