Skip to content

Conversation

@jsmeix
Copy link
Member

@jsmeix jsmeix commented Jul 29, 2016

In general see #841

For the particular state see
#841 (comment)

@jsmeix jsmeix added the enhancement Adaptions and new features label Jul 29, 2016
@jsmeix jsmeix added this to the Rear future milestone Jul 29, 2016
@jsmeix
Copy link
Member Author

jsmeix commented Jul 29, 2016

@gdha
please have a look and
if it is o.k. for you, please merge it.

It is a pure additional functionality so that
it cannot cause backward incompatible regressions.

@jsmeix
Copy link
Member Author

jsmeix commented Aug 1, 2016

Got no objections and I cannot imagine what could break
but I think it is a first step that could help a lot
so that I merge it now.

@jsmeix jsmeix merged commit 2e3919f into rear:master Aug 1, 2016
@jsmeix jsmeix modified the milestones: Rear v1.19, Rear future Aug 1, 2016
@jsmeix jsmeix deleted the first_steps_for_download_config_issue841 branch August 1, 2016 10:23
# therefore the HTTP response code is written to stdout ('-w') so that it can be explicitly tested afterwards
# ('-s' does not show progress meter or error messages but 'S' it makes it show an error message if it fails)
# "curl --verbose" messages go to stderr so that they go to the "rear recover" log file:
local http_response_code=$( curl $verbose -f -s -S -w "%{http_code}" -o /$update_archive_filename $RECOVERY_UPDATE_URL )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsmeix just make sure that curl is added to the REQUIRED_PROGS array if we depend on it in recovery mode.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdha
in my current first step state one must do that manually via

REQUIRED_PROGS=( "${REQUIRED_PROGS[@]}" curl )

see my description in default.conf.
The new RECOVERY_UPDATE_URL functionality
will require further enhancements and then - as needed
by the usres - I will try to make things work more
automatically right out of the box.

@jsmeix
Copy link
Member Author

jsmeix commented Aug 1, 2016

Unfortunately in the Git commit message
I used the outdated config variable name
RECOVERY_CONFIG_URL.
The right name is RECOVERY_UPDATE_URL.
See default.conf how RECOVERY_UPDATE_URL works.

@jsmeix
Copy link
Member Author

jsmeix commented Aug 1, 2016

For a possible use case, see #943
in particular see #943 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adaptions and new features fixed / solved / done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants