Skip to content

Conversation

@jsmeix
Copy link
Member

@jsmeix jsmeix commented Jul 7, 2016

automatically load fuse kernel module also for sshfs
in the same way as it is already done for ftpfs
cf. issue845

…as it is already done for ftpfs cf. issue845
@jsmeix jsmeix added enhancement Adaptions and new features bug The code does not do what it is meant to do labels Jul 7, 2016
@jsmeix jsmeix added this to the Rear v1.19 milestone Jul 7, 2016
@jsmeix jsmeix assigned jsmeix and gdha Jul 7, 2016
@jsmeix
Copy link
Member Author

jsmeix commented Jul 7, 2016

@gdha
please have a look if it looks o.k. for you.

For the reason behind see the
"FUSE sshfs Problem while recovering a Centos7 System"
mail thread in July 2016 on the rear-users mailing lis
in particular see
http://lists.relax-and-recover.org/pipermail/rear-users/2016-July/003376.html
(excerpts):

< BACKUP_URL=sshfs://sambasave@10.2.3.4/home/sambasave/Backup
> MODULES_LOAD=( vmxnet vmxnet3 e1000e e1000 fuse hpsa )
...
> When I ty to recover I get a message like :
> "can't load FUSEFS please load the fuse module"
...
In particular regarding loading the fuse kernel module
automatically (regardless of MODULES_LOAD) when 
BACKUP_URL=sshfs://...
I assume the mount_url() function in
usr/share/rear/lib/global-functions.sh
needs to be enhanced for sshfs in the same way
as I implemented it for the ftpfs case, cf.
https://github.com/rear/rear/issues/845
and
https://github.com/rear/rear/pull/859

@gdha
Copy link
Member

gdha commented Jul 7, 2016

@jsmeix I prefer to make a generic solution instead of a protocol by protocol fix, by fixing it in ./skel/default/etc/scripts/system-setup.d/40-start-udev-or-load-modules.sh and load always at the end /etc/modules

gdha added a commit that referenced this pull request Jul 7, 2016
…ted, so that

we always load the modules listed in /etc/modules (set by MODULES_LOAD)
Issue #905
@gdha
Copy link
Member

gdha commented Jul 7, 2016

@jsmeix I think you can close the pull request as I made a generic fix?

@jsmeix
Copy link
Member Author

jsmeix commented Jul 11, 2016

@gdha
the generic fix in 0ec8716
does not work for me, see
0ec8716#commitcomment-18192197

Regardless that the generic fix does not yet work for me
I agree that a generic fix is the right way to solve it.

Nevertheless as a temporary band-aid I merge my
current pull request until the generic fix actually works.

When the generic fix actually works I will remove only
the "modprobe fuse" lines but I like to keep the other tests
because I prefer to error out in case of errors than to blindly
proceed cf. https://github.com/rear/rear/wiki/Coding-Style

@jsmeix jsmeix merged commit f6e54dd into rear:master Jul 11, 2016
@jsmeix jsmeix deleted the automatically_load_fuse_for_sshfs_cf_issue845 branch July 12, 2016 12:24
@jsmeix
Copy link
Member Author

jsmeix commented Jul 12, 2016

I found out that in practice one cannot omit
the additional "modprobe fuse" for sshfs and ftpfs
for the mount_url() function in
usr/share/rear/lib/global-functions.sh
because without it:

# grep -v ^# etc/rear/local.conf 
OUTPUT=ISO
BACKUP=NETFS
BACKUP_OPTIONS="nfsvers=3,nolock"
BACKUP_URL=ftpfs://johannes@10.160.4.244/rear
...
# usr/sbin/rear -d -D mkbackup
Relax-and-Recover 1.18 / Git
Using log file: /root/rear/var/log/rear/rear-f121.log
ERROR: Mount command 'curlftpfs --verbose -o user='johannes' ftp://10.160.4.244/rear /tmp/rear.aFr3j7dXQcBGKFg/outputfs' failed.
Aborting due to an error, check /root/rear/var/log/rear/rear-f121.log for details
Terminated

I.e. the generic fix in #909
only loads the 'fuse' kernel module during "rear recover"
but to make "rear mkbackup" just working one still needs
the additional "modprobe fuse" for sshfs and ftpfs
for the mount_url() function in
usr/share/rear/lib/global-functions.sh

Because the additional "modprobe fuse" don't hurt
I keep it as it is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug The code does not do what it is meant to do enhancement Adaptions and new features fixed / solved / done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants