Skip to content

Decommission status improvement #24508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmaslankaprv merged 3 commits into from
Feb 25, 2025
Merged

Decommission status improvement #24508

mmaslankaprv merged 3 commits into from
Feb 25, 2025

Conversation

@mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Dec 10, 2024 •
edited
Loading

Improved accuracy of partition move progress Reported by Redpanda in admin APIs.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@mmaslankaprv
Copy link
Member Author

mmaslankaprv commented Dec 10, 2024

/dt

@mmaslankaprv mmaslankaprv force-pushed the decommission-status-improvement branch from 1ed6026 to 6e37c19 Compare December 12, 2024 11:43
@mmaslankaprv
Copy link
Member Author

mmaslankaprv commented Dec 12, 2024

/dt

@mmaslankaprv
cluster: use chunked_vector when reporting reconciliation status
7977311 
Signed-off-by: Michał Maślanka <michal@redpanda.com>
@mmaslankaprv mmaslankaprv force-pushed the decommission-status-improvement branch from 6e37c19 to 224f56c Compare February 19, 2025 13:59
@mmaslankaprv
Copy link
Member Author

mmaslankaprv commented Feb 19, 2025

/dt

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Feb 19, 2025 •
edited
Loading

CI test results

test results on build#62019
test_id test_kind job_url test_status passed
rptest.tests.compaction_recovery_test.CompactionRecoveryTest.test_index_recovery ducktape https://buildkite.com/redpanda/redpanda/builds/62019#01951ef3-3657-44a1-8902-8b6bdcc069a1 FLAKY 1/4
rptest.tests.datalake.mount_unmount_test.MountUnmountIcebergTest.test_simple_remount.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/62019#01951ef3-3657-44a1-8902-8b6bdcc069a1 FLAKY 1/2
rptest.tests.partition_movement_test.SIPartitionMovementTest.test_shadow_indexing.num_to_upgrade=0.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/62019#01951ef6-31dc-4174-be23-7f56d673321f FLAKY 1/2
rptest.tests.scaling_up_test.ScalingUpTest.test_scaling_up_with_recovered_topic ducktape https://buildkite.com/redpanda/redpanda/builds/62019#01951ef6-31dc-4174-be23-7f56d673321f FLAKY 1/3
test results on build#62097
test_id test_kind job_url test_status passed
test_raft_rpunit.test_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/62097#01952749-1c67-404d-9d9c-07606a4c9d79 FLAKY 1/2
test results on build#62183
test_id test_kind job_url test_status passed
rptest.tests.scaling_up_test.ScalingUpTest.test_scaling_up_with_recovered_topic ducktape https://buildkite.com/redpanda/redpanda/builds/62183#01953822-4c09-4623-bdae-b15a0400ddc4 FLAKY 1/2
test_archiver_manager_smp_rpfixture.test_archiver_manager_smp_rpfixture unit https://buildkite.com/redpanda/redpanda/builds/62183#019537d9-47db-4db2-a240-86c31b082a12 FLAKY 1/2

@mmaslankaprv mmaslankaprv marked this pull request as ready for review February 21, 2025 06:53
dotnwat
dotnwat reviewed Feb 23, 2025
View reviewed changes
@mmaslankaprv
controller: expose recovery state from controller_api
75edb5f 
Exposed the recovery state from controller_api, the recovery state is a
metric providing insight into the process of follower recovery. The
state returned from recovery state is based on the raft leader follower
state. This makes the state most up to date and accurate. This will
allow us to present more up to date information to the users. Currently
we are using health reports which is delayed and may be inaccurate.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
@mmaslankaprv
controller: use recovery status when reporting move status
2820af3 
Signed-off-by: Michał Maślanka <michal@redpanda.com>
@mmaslankaprv mmaslankaprv force-pushed the decommission-status-improvement branch from 224f56c to 2820af3 Compare February 24, 2025 12:03
@mmaslankaprv mmaslankaprv requested a review from dotnwat February 24, 2025 12:03
@mmaslankaprv mmaslankaprv merged commit 0e9dc55 into redpanda-data:dev Feb 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotnwat dotnwat dotnwat approved these changes

@ztlpn ztlpn Awaiting requested review from ztlpn

@bharathv bharathv Awaiting requested review from bharathv

@bashtanov bashtanov Awaiting requested review from bashtanov

Assignees

No one assigned

Labels

area/redpanda

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmaslankaprv @vbotbuildovich @dotnwat