c/topic_table: notify ntp delta waiters in batches #24761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CI test resultstest results on build#60552
|
When installing a controller snapshot or creating a topic with many partitions, the number of pending deltas can grow quite large. Notify waiters in batches to avoid stalls. This should also fix the problem with controller_backend notification handler that will spawn a lot of ready tasks if the task quota is exceeded.
e98b5d3 to
6263550
Compare
7 tasks
bashtanov
reviewed
Jan 10, 2025
Contributor
bashtanov
left a comment
There was a problem hiding this comment.
I took a quick glance on the subscribers, it doesn't look like any of them rely on notifications being consistent with the current state. See comments for some concerns/suggestions regarding iteration.
bashtanov
approved these changes
Jan 13, 2025
Collaborator
|
/backport v24.3.x |
Collaborator
|
/backport v24.2.x |
Collaborator
|
Failed to create a backport PR to v24.2.x branch. I tried: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing a controller snapshot or creating a topic with many partitions, the number of pending deltas can grow quite large. Notify waiters in batches to avoid stalls. This should also fix the problem with controller_backend notification handler that will spawn a lot of ready tasks if the task quota is exceeded.
Backports Required
Release Notes