Skip to content

ducktape: rename basic_kafka_compat_tests.py #24858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dotnwat merged 2 commits into from
Jan 20, 2025
Merged

ducktape: rename basic_kafka_compat_tests.py #24858

dotnwat merged 2 commits into from
Jan 20, 2025

Conversation

@bharathv
Copy link
Contributor

@bharathv bharathv commented Jan 17, 2025 •
edited
Loading

Ducktape expects modules to have either "test_" prefix or "_test" suffix to make it an eligible test candidate. This particular test exists in the tree but is not being run.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@bharathv
ducktape: rename basic_kafka_compat_tests.py
c41d643 
Ducktape expects modules to have either "test_" or "_test.py" prefix to
make it an eligible test candidate. This particular test exists in the
tree but is not being run.
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 17, 2025 •
edited
Loading

Retry command for Build#60919

please wait until all jobs are finished before running the slash command


/ci-repeat 1
tests/rptest/tests/basic_kafka_compat_test.py::TxKafkaCompatTest.test_concurrent_producer_ids@{"metadata_quorum":"COLOCATED_KRAFT"}

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 17, 2025 •
edited
Loading

CI test results

test results on build#60919
test_id test_kind job_url test_status passed
rptest.tests.basic_kafka_compat_test.TxKafkaCompatTest.test_concurrent_producer_ids.metadata_quorum=COLOCATED_KRAFT ducktape https://buildkite.com/redpanda/redpanda/builds/60919#019475ae-bfa6-4e33-8049-3ce8d1ce5dc9 FAIL 0/1
rptest.tests.basic_kafka_compat_test.TxKafkaCompatTest.test_concurrent_producer_ids.metadata_quorum=COLOCATED_KRAFT ducktape https://buildkite.com/redpanda/redpanda/builds/60919#019475b2-a33c-4d27-8a31-d263e040c7b0 FAIL 0/1
rptest.tests.partition_reassignments_test.PartitionReassignmentsTest.test_reassignments_kafka_cli ducktape https://buildkite.com/redpanda/redpanda/builds/60919#019475ae-bfa7-43d4-b234-f2fd97cb7834 FLAKY 1/5
rptest.tests.partition_reassignments_test.PartitionReassignmentsTest.test_reassignments_kafka_cli ducktape https://buildkite.com/redpanda/redpanda/builds/60919#019475b2-a33c-4d27-8a31-d263e040c7b0 FLAKY 1/2
test results on build#60940
test_id test_kind job_url test_status passed
rptest.tests.compaction_recovery_test.CompactionRecoveryUpgradeTest.test_index_recovery_after_upgrade ducktape https://buildkite.com/redpanda/redpanda/builds/60940#019481f0-f672-48b4-a929-97da30a7bdb1 FLAKY 1/2
rptest.tests.datalake.datalake_dlq_test.DatalakeDLQTest.test_dlq_table_for_mixed_records.cloud_storage_type=CloudStorageType.S3.query_engine=QueryEngineType.TRINO ducktape https://buildkite.com/redpanda/redpanda/builds/60940#019481f0-f672-47b4-9364-ba4a0a7531ef FLAKY 1/2

@dotnwat
Copy link
Member

dotnwat commented Jan 18, 2025

oh the test is failing. it was just never running?

@bharathv
tests/kafka_compat_test: fix metadata_quorum config
c0b4e9b 
The config names changed at somepoint in Apache Kafka.
@bharathv
Copy link
Contributor Author

bharathv commented Jan 20, 2025

oh the test is failing. it was just never running?

Fixed the test. it was never running.

@dotnwat dotnwat merged commit 226a084 into redpanda-data:dev Jan 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotnwat dotnwat dotnwat approved these changes

@mmaslankaprv mmaslankaprv mmaslankaprv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bharathv @vbotbuildovich @dotnwat @mmaslankaprv